Hi Chris/Mike,<br><br>I found and fixed one other issue and updated the patch. Here's the summary:<br>- Added support for setting the ownership and permissions for an FCGI socket<br>- Fixed bug where FCGI socket reference count was not getting decremented on spawn error<br>
<br>I updated the unit tests to verify the reference count fix.<br><br>Thanks,<br><br>Roger<br>
<br><div class="gmail_quote">On Fri, Oct 23, 2009 at 11:55 AM, Roger Hoover <span dir="ltr"><<a href="mailto:roger.hoover@gmail.com" target="_blank">roger.hoover@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Thanks, everyone. Attached is the patch with full unit tests.<br><br>Chris, I need to update the manual as well for the new fcgi-program options, socket_owner and socket_mode. I forget where that is. In another svn repo?<br>
<br>Thanks,<br><font color="#888888"><br>Roger</font><div><div></div><div><br><br><div class="gmail_quote">On Fri, Oct 23, 2009 at 9:57 AM, Chris McDonough <span dir="ltr"><<a href="mailto:chrism@plope.com" target="_blank">chrism@plope.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div>Roger Hoover wrote:<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Hmmm...the more I think about it., socket_owner and socket_mode are indeed better names. Chris/Mike, do you want to weigh in on consistency vs. clarity?<br>
</blockquote>
<br></div>
I'd be fine with either.<br><font color="#888888">
<br>
- C<br>
<br>
<br>
</font><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><div>
<br>
On Fri, Oct 23, 2009 at 9:08 AM, Roger Hoover <<a href="mailto:roger.hoover@gmail.com" target="_blank">roger.hoover@gmail.com</a> <mailto:<a href="mailto:roger.hoover@gmail.com" target="_blank">roger.hoover@gmail.com</a>>> wrote:<br>
<br>
<br>
<br>
On Fri, Oct 23, 2009 at 8:57 AM, Grzegorz Nosek <<a href="mailto:root@localdomain.pl" target="_blank">root@localdomain.pl</a><br></div><div><div></div><div>
<mailto:<a href="mailto:root@localdomain.pl" target="_blank">root@localdomain.pl</a>>> wrote:<br>
<br>
On Fri, Oct 23, 2009 at 08:33:28AM -0700, Roger Hoover wrote:<br>
> I'm most of the way there on #2. The issue is that as far as<br>
I can tell<br>
> there's no way to find out the umask for a user so I don't<br>
automatically<br>
> know what permissions to chmod the FCGI socket with. Now,<br>
the choices are<br>
><br>
> a) Don't chmod the FCGI socket, just chown it to the uid/gid<br>
of the user the<br>
> process will run as<br>
><br>
> b) Add socket_chown, socket_chmod args that only apply to<br>
unix domain<br>
> sockets. This allows the most control for the user but the<br>
fact that the<br>
> params don't always make sense is a bit awkward.<br>
><br>
> [fcgi-program:test]<br>
> command=/foo/bar.fcgi<br>
> socket=unix:///tmp/test.socket<br>
> socket_chown=rhoover:wheel ; this option would only apply to<br>
unix domain<br>
> sockets<br>
> socket_chmod=0777 ; this option would only apply to unix<br>
domain sockets<br>
> user=nobody<br>
> process_name=foo_%(process_num)s<br>
> numprocs=2<br>
><br>
> Anyone have an opinion here?<br>
<br>
I'm for explicit owner and mode options. Apache-style FastCGI<br>
wrappers<br>
are a pain.<br>
<br>
<br>
Thanks. I was leaning this direction.<br>
<br>
<br>
Also, my vote would go to naming these options "socket_owner" and<br>
"socket_mode" (or "socket_perm(s)"?) as I've heard enough of<br>
"setting<br>
chmods" in my day ;)<br>
<br>
<br>
That makes sense but I'm going for consistency with the existing<br>
unix_http_server section of the config. <a href="http://supervisord.org/manual/current/configuration.html#unix_http_server" target="_blank">http://supervisord.org/manual/current/configuration.html#unix_http_server</a><br>
<br>
<br>
Best regards,<br>
Grzegorz Nosek<br>
<br>
<br>
<br>
</div></div></blockquote>
<br>
</blockquote></div><br>
</div></div></blockquote></div><br>